[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 3.1 2/4] virtio: Check qemu_get_virtqueue_el
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH for 3.1 2/4] virtio: Check qemu_get_virtqueue_element returns |
|
Date: |
Tue, 17 Jul 2018 11:30:42 +0100 |
|
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Mon, Jul 16, 2018 at 06:37:41PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Check calls to qemu_get_virtqueue_element for NULL and pass
> up the chain.
What happens to the device state that has been partially deserialized
(e.g. virtio-blk's s->rq linked list)?
It's not clear to me that simply returning NULL is enough to put QEMU
into a sane state without memory leaks or crashes if we decide to retry.
signature.asc
Description: PGP signature