Re: [Qemu-devel] [PATCH] linux-user: fix ELF load alignment error

[Richard Henderson]

On 07/16/2018 12:53 PM, Laurent Vivier wrote:
> When we try to use some targets on ppc64, it can happen the target
> doesn't support the host page size to align ELF load sections and
> fails with:
> 
>   ELF load command alignment not page-aligned
> 
> Since commit a70daba3771 ("linux-user: Tell guest about big host
> page sizes") the host page size is used to align ELF sections, but
> this doesn't work if the alignment required by the load section is
> smaller than the host one.  For these cases, we continue to use the
> TARGET_PAGE_SIZE instead of the host one.
> 
> I have tested this change on ppc64, and it fixes qemu linux-user for:
>   s390x, m68k, i386, arm, aarch64, hppa
> and I have tested it doesn't break the following targets:
>   x86_64, mips64el, sh4
> mips and mipsel abort, but I think for another reason.
...
>      loaddr = -1, hiaddr = 0;
> +    info->alignment |=  0;

Plain assignment for initialization.

Otherwise,
Reviewed-by: Richard Henderson <address@hidden>


r~