[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 02/29] chardev: remove qemu_chr_fe_read_all() cou
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH v4 02/29] chardev: remove qemu_chr_fe_read_all() counter |
Date: |
Fri, 13 Jul 2018 15:08:49 +0200 |
There is no obvious reason to have a loop counter. This limits from
reading several megabytes large buffers in one go, since socket
read/write usually have a limit.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
---
chardev/char-fe.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/chardev/char-fe.c b/chardev/char-fe.c
index b1f228e8b5..f158f158f8 100644
--- a/chardev/char-fe.c
+++ b/chardev/char-fe.c
@@ -56,7 +56,7 @@ int qemu_chr_fe_write_all(CharBackend *be, const uint8_t
*buf, int len)
int qemu_chr_fe_read_all(CharBackend *be, uint8_t *buf, int len)
{
Chardev *s = be->chr;
- int offset = 0, counter = 10;
+ int offset = 0;
int res;
if (!s || !CHARDEV_GET_CLASS(s)->chr_sync_read) {
@@ -88,10 +88,6 @@ int qemu_chr_fe_read_all(CharBackend *be, uint8_t *buf, int
len)
}
offset += res;
-
- if (!counter--) {
- break;
- }
}
if (qemu_chr_replay(s) && replay_mode == REPLAY_MODE_RECORD) {
--
2.18.0.129.ge3331758f1
- [Qemu-devel] [PATCH v4 00/29] vhost-user for input & GPU, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 01/29] chardev: avoid crash if no associated address, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 03/29] chardev: unref if underlying chardev has no parent, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 02/29] chardev: remove qemu_chr_fe_read_all() counter,
Marc-André Lureau <=
- [Qemu-devel] [PATCH v4 04/29] dmabuf: add y0_top, pass it to spice, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 06/29] libvhost-user: exit by default on VHOST_USER_NONE, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 05/29] vhost-user: simplify vhost_user_init/vhost_user_cleanup, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 07/29] vhost-user: wrap some read/write with retry handling, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 08/29] Add vhost-user-backend, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 09/29] qio: add qio_channel_command_new_spawn_with_pre_exec(), Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 10/29] HACK: vhost-user-backend: allow to specify binary to execute, Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 11/29] vhost-user: split vhost_user_read(), Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 12/29] vhost-user: add vhost_user_input_get_config(), Marc-André Lureau, 2018/07/13
- [Qemu-devel] [PATCH v4 13/29] libvhost-user: export vug_source_new(), Marc-André Lureau, 2018/07/13