[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/12] qmp: constify qmp_is_oob()
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 03/12] qmp: constify qmp_is_oob() |
Date: |
Thu, 12 Jul 2018 14:27:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> include/qapi/qmp/dispatch.h | 2 +-
> qapi/qmp-dispatch.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/qapi/qmp/dispatch.h b/include/qapi/qmp/dispatch.h
> index 4e2e749faf..68a528a9aa 100644
> --- a/include/qapi/qmp/dispatch.h
> +++ b/include/qapi/qmp/dispatch.h
> @@ -50,7 +50,7 @@ bool qmp_has_success_response(const QmpCommand *cmd);
> QDict *qmp_error_response(Error *err);
> QDict *qmp_dispatch(QmpCommandList *cmds, QObject *request,
> bool allow_oob);
> -bool qmp_is_oob(QDict *dict);
> +bool qmp_is_oob(const QDict *dict);
>
> typedef void (*qmp_cmd_callback_fn)(QmpCommand *cmd, void *opaque);
>
> diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
> index 6f2d466596..90ba5e3074 100644
> --- a/qapi/qmp-dispatch.c
> +++ b/qapi/qmp-dispatch.c
> @@ -156,7 +156,7 @@ QDict *qmp_error_response(Error *err)
> /*
> * Does @qdict look like a command to be run out-of-band?
> */
> -bool qmp_is_oob(QDict *dict)
> +bool qmp_is_oob(const QDict *dict)
> {
> return qdict_haskey(dict, "exec-oob")
> && !qdict_haskey(dict, "execute");
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-devel] [PATCH 10/12] tests: add a qmp success-response test, (continued)
- [Qemu-devel] [PATCH 10/12] tests: add a qmp success-response test, Marc-André Lureau, 2018/07/06
- [Qemu-devel] [PATCH 11/12] qga: process_event() simplification, Marc-André Lureau, 2018/07/06
- [Qemu-devel] [PATCH 12/12] RFC: qmp: rework 'id' handling, Marc-André Lureau, 2018/07/06
- [Qemu-devel] [PATCH 01/12] tests: change /0.15/* tests to /qmp/*, Marc-André Lureau, 2018/07/06
- [Qemu-devel] [PATCH 02/12] monitor: consitify qmp_send_response() QDict argument, Marc-André Lureau, 2018/07/06
- [Qemu-devel] [PATCH 03/12] qmp: constify qmp_is_oob(), Marc-André Lureau, 2018/07/06
- Re: [Qemu-devel] [PATCH 03/12] qmp: constify qmp_is_oob(),
Markus Armbruster <=