qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 16/20] migration-test: Make wait_command() cope


From: Juan Quintela
Subject: Re: [Qemu-devel] [PATCH 16/20] migration-test: Make wait_command() cope with '%'
Date: Thu, 12 Jul 2018 13:23:53 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Markus Armbruster <address@hidden> wrote:
> wait_command() passes its argument @command to qtest_qmp_send().
> Falls apart if @command contain '%'.  Two ways to disarm this trap:
> suppress interpretation of '%' by passing @command as argument to
> format string "%s", or fix it by having wait_command() take the
> variable arguments to go with @command.  Do the latter.
>
> This is another step towards compile-time format string checking
> without triggering -Wformat-nonliteral.
>
> Cc: Juan Quintela <address@hidden>
> Cc: Dr. David Alan Gilbert <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>

Reviewed-by: Juan Quintela <address@hidden>

much better.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]