[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 23/24] block: Fix bdrv_co_truncate overlap check
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 23/24] block: Fix bdrv_co_truncate overlap check |
Date: |
Tue, 10 Jul 2018 17:43:03 +0200 |
From: Fam Zheng <address@hidden>
If we are growing the image and potentially using preallocation for the
new area, we need to make sure that no write requests are made to the
"preallocated" area which is address@hidden, @offset), not
address@hidden, offset * 2 - @old_size).
Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
block/io.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/io.c b/block/io.c
index 2832214db4..77d38ca1d3 100644
--- a/block/io.c
+++ b/block/io.c
@@ -3136,7 +3136,8 @@ int coroutine_fn bdrv_co_truncate(BdrvChild *child,
int64_t offset,
}
bdrv_inc_in_flight(bs);
- tracked_request_begin(&req, bs, offset, new_bytes, BDRV_TRACKED_TRUNCATE);
+ tracked_request_begin(&req, bs, offset - new_bytes, new_bytes,
+ BDRV_TRACKED_TRUNCATE);
/* If we are growing the image and potentially using preallocation for the
* new area, we need to make sure that no write requests are made to it
--
2.13.6
- [Qemu-devel] [PULL 15/24] block: Prefix file driver trace points with "file_", (continued)
- [Qemu-devel] [PULL 15/24] block: Prefix file driver trace points with "file_", Kevin Wolf, 2018/07/10
- [Qemu-devel] [PULL 13/24] Revert "block: Remove deprecated -drive option addr", Kevin Wolf, 2018/07/10
- [Qemu-devel] [PULL 12/24] Revert "block: Remove deprecated -drive option serial", Kevin Wolf, 2018/07/10
- [Qemu-devel] [PULL 16/24] block: Add copy offloading trace points, Kevin Wolf, 2018/07/10
- [Qemu-devel] [PULL 14/24] Revert "block: Remove deprecated -drive geometry options", Kevin Wolf, 2018/07/10
- [Qemu-devel] [PULL 18/24] block: Use uint64_t for BdrvTrackedRequest byte fields, Kevin Wolf, 2018/07/10
- [Qemu-devel] [PULL 22/24] block: Use common req handling in copy offloading, Kevin Wolf, 2018/07/10
- [Qemu-devel] [PULL 21/24] block: Use common req handling for discard, Kevin Wolf, 2018/07/10
- [Qemu-devel] [PULL 19/24] block: Extract common write req handling, Kevin Wolf, 2018/07/10
- [Qemu-devel] [PULL 20/24] block: Fix handling of image enlarging write, Kevin Wolf, 2018/07/10
- [Qemu-devel] [PULL 23/24] block: Fix bdrv_co_truncate overlap check,
Kevin Wolf <=
- [Qemu-devel] [PULL 17/24] block: Use BdrvChild to discard, Kevin Wolf, 2018/07/10
- [Qemu-devel] [PULL 24/24] block: Use common write req handling in truncate, Kevin Wolf, 2018/07/10
- Re: [Qemu-devel] [PULL 00/24] Block layer patches, Peter Maydell, 2018/07/10