[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-3.0 v2 05/10] tests: introduce migrate_postcopy_
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH for-3.0 v2 05/10] tests: introduce migrate_postcopy_* helpers |
Date: |
Tue, 10 Jul 2018 17:18:57 +0800 |
Separate the old postcopy UNIX socket test into three steps, provide a
helper for each step. With these helpers, we can do more compliated
tests like postcopy recovery, while keep the codes shared.
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Reviewed-by: Balamuruhan S <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
---
tests/migration-test.c | 38 +++++++++++++++++++++++++++-----------
1 file changed, 27 insertions(+), 11 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 3a85446f95..2155869b96 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -351,13 +351,19 @@ static void migrate(QTestState *who, const char *uri)
qobject_unref(rsp);
}
-static void migrate_start_postcopy(QTestState *who)
+static void migrate_postcopy_start(QTestState *from, QTestState *to)
{
QDict *rsp;
- rsp = wait_command(who, "{ 'execute': 'migrate-start-postcopy' }");
+ rsp = wait_command(from, "{ 'execute': 'migrate-start-postcopy' }");
g_assert(qdict_haskey(rsp, "return"));
qobject_unref(rsp);
+
+ if (!got_stop) {
+ qtest_qmp_eventwait(from, "STOP");
+ }
+
+ qtest_qmp_eventwait(to, "RESUME");
}
static void test_migrate_start(QTestState **from, QTestState **to,
@@ -505,7 +511,8 @@ static void test_deprecated(void)
qtest_quit(from);
}
-static void test_postcopy(void)
+static void migrate_postcopy_prepare(QTestState **from_ptr,
+ QTestState **to_ptr)
{
char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
QTestState *from, *to;
@@ -527,28 +534,37 @@ static void test_postcopy(void)
wait_for_serial("src_serial");
migrate(from, uri);
+ g_free(uri);
wait_for_migration_pass(from);
- migrate_start_postcopy(from);
-
- if (!got_stop) {
- qtest_qmp_eventwait(from, "STOP");
- }
+ *from_ptr = from;
+ *to_ptr = to;
+}
- qtest_qmp_eventwait(to, "RESUME");
+static void migrate_postcopy_complete(QTestState *from, QTestState *to)
+{
+ wait_for_migration_complete(from);
+ /* Make sure we get at least one "B" on destination */
wait_for_serial("dest_serial");
- wait_for_migration_complete(from);
if (uffd_feature_thread_id) {
read_blocktime(to);
}
- g_free(uri);
test_migrate_end(from, to, true);
}
+static void test_postcopy(void)
+{
+ QTestState *from, *to;
+
+ migrate_postcopy_prepare(&from, &to);
+ migrate_postcopy_start(from, to);
+ migrate_postcopy_complete(from, to);
+}
+
static void test_baddest(void)
{
QTestState *from, *to;
--
2.17.1
- [Qemu-devel] [PATCH for-3.0 v2 00/10] migration: postcopy recovery unit test, bug fixes, Peter Xu, 2018/07/10
- [Qemu-devel] [PATCH for-3.0 v2 01/10] migration: simplify check to use qemu file buffer, Peter Xu, 2018/07/10
- [Qemu-devel] [PATCH for-3.0 v2 02/10] migration: loosen recovery check when load vm, Peter Xu, 2018/07/10
- [Qemu-devel] [PATCH for-3.0 v2 03/10] migration: fix incorrect bitmap size calculation, Peter Xu, 2018/07/10
- [Qemu-devel] [PATCH for-3.0 v2 04/10] migration: show pause/recover state on dst host, Peter Xu, 2018/07/10
- [Qemu-devel] [PATCH for-3.0 v2 05/10] tests: introduce migrate_postcopy_* helpers,
Peter Xu <=
- [Qemu-devel] [PATCH for-3.0 v2 06/10] tests: allow migrate() to take extra flags, Peter Xu, 2018/07/10
- [Qemu-devel] [PATCH for-3.0 v2 07/10] tests: introduce migrate_query*() helpers, Peter Xu, 2018/07/10
- [Qemu-devel] [PATCH for-3.0 v2 08/10] tests: introduce wait_for_migration_status(), Peter Xu, 2018/07/10
- [Qemu-devel] [PATCH for-3.0 v2 09/10] tests: add postcopy recovery test, Peter Xu, 2018/07/10
- [Qemu-devel] [PATCH for-3.0 v2 10/10] tests: hide stderr for postcopy recovery test, Peter Xu, 2018/07/10
- Re: [Qemu-devel] [PATCH for-3.0 v2 00/10] migration: postcopy recovery unit test, bug fixes, Dr. David Alan Gilbert, 2018/07/10