[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom()
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom() |
Date: |
Fri, 6 Jul 2018 18:40:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/06/2018 06:25 PM, Michael S. Tsirkin wrote:
> On Fri, Jul 06, 2018 at 05:55:23PM +0200, Paolo Bonzini wrote:
>> On 06/07/2018 03:51, Peter Xu wrote:
>>>
>>> A question about memory region auto destruction (which might not
>>> related to this patch): I see that we have object_property_add_child()
>>> in memory_region_do_init() to achieve the auto destruction but only if
>>> the "name" of memory region is specified. Could we just do that
>>> unconditionally (though we might of course need to generate some of
>>> the names), or is there a reason not to do so?
>>
>> I'm not sure actually if there are still regions without a name...
>>
>> Paolo
>
> Answer to Peter's question would be a yes then?
>
> With all the autodestruct I'm unsure when is calling vmstate_unregister_ram
> appropriate.
> Is it necessary to invoke that from pci any longer?
That could be another patch though. This is trying to fix vfio-pci
unplug.
C.
- [Qemu-devel] [PATCH] pci: remove pci_del_option_rom(), Cédric Le Goater, 2018/07/05
- Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom(), Michael S. Tsirkin, 2018/07/05
- Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom(), Alex Williamson, 2018/07/05
- Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom(), Paolo Bonzini, 2018/07/05
- Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom(), Peter Xu, 2018/07/05
- Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom(), Paolo Bonzini, 2018/07/06
- Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom(), Michael S. Tsirkin, 2018/07/06
- Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom(),
Cédric Le Goater <=
- Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom(), Paolo Bonzini, 2018/07/06
- Re: [Qemu-devel] [PATCH] pci: remove pci_del_option_rom(), Michael S. Tsirkin, 2018/07/06