[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] sam460ex: Add comment explaining ignored errors
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] sam460ex: Add comment explaining ignored errors from fdt operations |
|
Date: |
Fri, 6 Jul 2018 14:41:18 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/07/2018 03:18, David Gibson wrote:
>> Ok, but why would it even fail? Maybe it's not this case, but even if
>> it's not fatal for the OS, generating different device trees silently
>> seems like a recipe for Heisenbugs.
> Yes, quite. Especially since the most likely errors I can see here
> would actually indicate something has already gone horribly wrong with
> the device tree construction, so a missing clock-frequency is the
> least of our troubles.
>
> I think using _FDT() here would be a better approach.
Or qemu_fdt_setprop_cell, which is there exactly for this reason.
Volunteers needed to report it in checkpatch! :)
Paolo
signature.asc
Description: OpenPGP digital signature