[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC] target/arm: Suppress Coverity warning for PRF
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [RFC] target/arm: Suppress Coverity warning for PRF |
Date: |
Thu, 5 Jul 2018 11:04:03 -0700 |
These instructions must perform the sve_access_check, but
since they are implemented as NOPs there is no generated
code to elide when the access check fails.
Fixes: Coverity issues 1393780 & 1393779.
Signed-off-by: Richard Henderson <address@hidden>
---
Does anyone know if this actually works for Coverity?
I'd hate to churn the code without knowing.
---
target/arm/translate-sve.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index c080345b9c..d41f1155f9 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -5164,7 +5164,7 @@ static bool trans_ST1_zpiz(DisasContext *s, arg_ST1_zpiz
*a, uint32_t insn)
static bool trans_PRF(DisasContext *s, arg_PRF *a, uint32_t insn)
{
/* Prefetch is a nop within QEMU. */
- sve_access_check(s);
+ (void)sve_access_check(s);
return true;
}
@@ -5174,7 +5174,7 @@ static bool trans_PRF_rr(DisasContext *s, arg_PRF_rr *a,
uint32_t insn)
return false;
}
/* Prefetch is a nop within QEMU. */
- sve_access_check(s);
+ (void)sve_access_check(s);
return true;
}
--
2.17.1
- [Qemu-devel] [RFC] target/arm: Suppress Coverity warning for PRF,
Richard Henderson <=