qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v1 06/11] memory-device: add device class function s


From: David Hildenbrand
Subject: [Qemu-devel] [PATCH v1 06/11] memory-device: add device class function set_addr()
Date: Thu, 5 Jul 2018 13:59:38 +0200

To be able to factor out address asignment of memory devices, we will
have to read (get_addr()) and write (set_addr()) the address. We cannot
use properties for this purpose, as properties are device specific. E.g.
while the address property for a DIMM is called "addr", it might be
called differently (e.g. "phys_addr") for other devices. E.g. virtio
based memory devices cannot use "addr" as that is already reserved and
used for the virtio device address on the bus.

Signed-off-by: David Hildenbrand <address@hidden>
---
 include/hw/mem/memory-device.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/hw/mem/memory-device.h b/include/hw/mem/memory-device.h
index 0c1fd66b68..cf5d182ac2 100644
--- a/include/hw/mem/memory-device.h
+++ b/include/hw/mem/memory-device.h
@@ -34,6 +34,7 @@ typedef struct MemoryDeviceState {
  * @get_addr: The address of the @md in guest physical memory. "0" means that
  * no address has been specified by the user and that no address has been
  * assigned yet.
+ * @set_addr: Set the address of the @md in guest physical memory.
  * @get_plugged_size: The the amount of memory provided by this @md
  * currently usable ("plugged") by the guest. Will not fail after the device
  * was realized.
@@ -47,6 +48,7 @@ typedef struct MemoryDeviceClass {
 
     /* public */
     uint64_t (*get_addr)(const MemoryDeviceState *md);
+    void (*set_addr)(MemoryDeviceState *md, uint64_t addr, Error **errp);
     uint64_t (*get_plugged_size)(const MemoryDeviceState *md, Error **errp);
     MemoryRegion *(*get_memory_region)(MemoryDeviceState *md, Error **errp);
     void (*fill_device_info)(const MemoryDeviceState *md,
-- 
2.17.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]