[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/8] error: Remove NULL checks on error_propagat
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH 2/8] error: Remove NULL checks on error_propagate() calls |
Date: |
Thu, 5 Jul 2018 10:49:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 04.07.2018 17:39, Philippe Mathieu-Daudé wrote:
> Patch created mechanically by rerunning:
>
> $ spatch --sp-file scripts/coccinelle/error_propagate_null.cocci \
> --macro-file scripts/cocci-macro-file.h \
> --dir . --in-place
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/s390x/virtio-ccw.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
> index b92a85d0b0..7ddb378d52 100644
> --- a/hw/s390x/virtio-ccw.c
> +++ b/hw/s390x/virtio-ccw.c
> @@ -1836,11 +1836,9 @@ static void vhost_vsock_ccw_realize(VirtioCcwDevice
> *ccw_dev, Error **errp)
> {
> VHostVSockCCWState *dev = VHOST_VSOCK_CCW(ccw_dev);
> DeviceState *vdev = DEVICE(&dev->vdev);
> - Error *err = NULL;
>
> qdev_set_parent_bus(vdev, BUS(&ccw_dev->bus));
> - object_property_set_bool(OBJECT(vdev), true, "realized", &err);
> - error_propagate(errp, err);
> + object_property_set_bool(OBJECT(vdev), true, "realized", errp);
> }
>
> static void vhost_vsock_ccw_class_init(ObjectClass *klass, void *data)
>
Reviewed-by: David Hildenbrand <address@hidden>
--
Thanks,
David / dhildenb
- [Qemu-devel] [PATCH 0/8] Coccinelle cleanups, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 1/8] qobject: Catch another straggler for use of qdict_put_str(), Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 2/8] error: Remove NULL checks on error_propagate() calls, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 3/8] crypto: Remove useless casts, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 4/8] xen: Remove useless casts, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 5/8] tests/bios-tables-test: Remove useless casts, Philippe Mathieu-Daudé, 2018/07/04