[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/8] ui/vnc: Remove useless parenthesis around D
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 6/8] ui/vnc: Remove useless parenthesis around DIV_ROUND_UP macro |
Date: |
Thu, 05 Jul 2018 07:39:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> Patch created mechanically by rerunning:
>
> $ spatch --sp-file scripts/coccinelle/round.cocci \
> --macro-file scripts/cocci-macro-file.h \
> --dir . --in-place
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> ui/vnc-enc-tight.c | 2 +-
> ui/vnc.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
> index f38aceb4da..0b4a5ac71f 100644
> --- a/ui/vnc-enc-tight.c
> +++ b/ui/vnc-enc-tight.c
> @@ -979,7 +979,7 @@ static int send_mono_rect(VncState *vs, int x, int y,
> }
> #endif
>
> - bytes = (DIV_ROUND_UP(w, 8)) * h;
> + bytes = DIV_ROUND_UP(w, 8) * h;
>
> vnc_write_u8(vs, (stream | VNC_TIGHT_EXPLICIT_FILTER) << 4);
> vnc_write_u8(vs, VNC_TIGHT_FILTER_PALETTE);
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 359693238b..3361432a51 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -2967,7 +2967,8 @@ static int vnc_refresh_server_surface(VncDisplay *vd)
> PIXMAN_FORMAT_BPP(pixman_image_get_format(vd->guest.fb));
> guest_row0 = (uint8_t *)pixman_image_get_data(vd->guest.fb);
> guest_stride = pixman_image_get_stride(vd->guest.fb);
> - guest_ll = pixman_image_get_width(vd->guest.fb) *
> (DIV_ROUND_UP(guest_bpp, 8));
> + guest_ll = pixman_image_get_width(vd->guest.fb)
> + * DIV_ROUND_UP(guest_bpp, 8);
> }
> line_bytes = MIN(server_stride, guest_ll);
Reviewed-by: Markus Armbruster <address@hidden>
- Re: [Qemu-devel] [PATCH 3/8] crypto: Remove useless casts, (continued)
- [Qemu-devel] [PATCH 4/8] xen: Remove useless casts, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 5/8] tests/bios-tables-test: Remove useless casts, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 6/8] ui/vnc: Remove useless parenthesis around DIV_ROUND_UP macro, Philippe Mathieu-Daudé, 2018/07/04
- Re: [Qemu-devel] [PATCH 6/8] ui/vnc: Remove useless parenthesis around DIV_ROUND_UP macro,
Markus Armbruster <=
- [Qemu-devel] [PATCH 8/8] hw/intc/gicv3: Remove useless parenthesis around DIV_ROUND_UP macro, Philippe Mathieu-Daudé, 2018/07/04
- [Qemu-devel] [PATCH 7/8] hw/pci-host: Remove useless parenthesis around DIV_ROUND_UP macro, Philippe Mathieu-Daudé, 2018/07/04
- Re: [Qemu-devel] [PATCH 0/8] Coccinelle cleanups, Markus Armbruster, 2018/07/05
- Re: [Qemu-devel] [PATCH 0/8] Coccinelle cleanups, Michael S. Tsirkin, 2018/07/05