Re: [Qemu-devel] [PATCH v2 4/6] tests/acceptance: Add a BootLinuxConsoleMips test

[Eduardo Habkost]

On Wed, Jul 04, 2018 at 06:44:02PM -0300, Philippe Mathieu-Daudé wrote:
> On 07/04/2018 05:47 PM, Eduardo Habkost wrote:
> > On Wed, Jul 04, 2018 at 04:56:44PM -0300, Philippe Mathieu-Daudé wrote:
> >> On 06/28/2018 07:45 PM, Philippe Mathieu-Daudé wrote:
> >>> On 06/28/2018 03:36 PM, Alex Bennée wrote:
> >>>> Philippe Mathieu-Daudé <address@hidden> writes:
> >>>>> On 06/28/2018 01:23 PM, Alex Bennée wrote:
> > [...]
> >>>>>>> +    def test(self):
> >>>>>>> +        kernel_url = ('http://people.debian.org/~aurel32/qemu/mips/'
> >>>>>>> +                      'vmlinux-3.2.0-4-4kc-malta')
> >>>>>>> +        kernel_hash = '592e384a4edc16dade52a6cd5c785c637bcbc9ad'
> >>>>>>> +        kernel_path = self.fetch_asset(kernel_url,
> >>>>>>> asset_hash=kernel_hash)
> >>>>>>
> >>>>>> I'm uncomfortable using "random" binaries of websites as the source of
> >>>>>> our test kernels. I can see the justification for distro kernels as 
> >>>>>> they
> >>>>>> at least have the infrastructure to rebuild from source if you really
> >>>>>> want to, but even then the distros don't cover a lot of the
> >>>>>> architectures.
> >>
> >> Alex: I could find all the Linux kernel I'm interested to console-test
> >> with Avocado on the http://snapshot.debian.org/ archive website.
> >>
> >> For example Aurelien's one (more up-to-date) is available here:
> >> http://snapshot.debian.org/package/linux-2.6/2.6.32-48/#linux-image-2.6.32-5-4kc-malta_2.6.32-48
> >>
> >> I also added a SH-4 test for the SM501 series of Zoltan BALATON using
> >> the kernel extracted from this distrib built kernel:
> >> http://snapshot.debian.org/package/linux-2.6/2.6.32-30/#linux-image-2.6.32-5-sh7751r_2.6.32-30
> >>
> >> The Debian distribution also provide the source package and the kernels
> >> can be simply rebuilt using make-kpkg or (make bindeb-pkg with more
> >> recent kernels).
> >>
> >> Would it be enough to satisfy the GPL requirements to provided that info
> >> in the header and use these handy pre-compiled kernels?
> > 
> > (IANAL, etc.)
> > 
> > Personally, I would try to avoid dealing with the "written offer"
> > option of the GPL, and just publish the sources in the same
> > medium (HTTP download repository, git repository, etc) as the
> > binary.
> 
> About Debian packaged kernel: the sources are in the same directory:
> 
> http://snapshot.debian.org/package/linux-2.6/2.6.32-30/
> 
> linux-2.6_2.6.32.orig.tar.gz
> linux-image-2.6.32-5-sh7751r_2.6.32-30_sh4.deb
> linux-support-2.6.32-5_2.6.32-30_all.deb

Oh, I thought you were talking about publishing the binaries
elsewhere.  If we're not the ones publishing the binaries (we're
just downloading it), then this is somebody else's problem.  :)

Would it be OK to make test code download directly from
snapshot.debian.org, though?  Their home page have instructions
to use apt repositories there, so I guess it's reasonable use of
the service.

-- 
Eduardo