[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration() |
|
Date: |
Wed, 4 Jul 2018 15:06:49 -0300 |
|
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Wed, Jul 04, 2018 at 09:22:39PM +0800, Dou Liyang wrote:
> Commit 7a3099fc9c5c("numa: postpone options post-processing till
> machine_run_board_init()")
> broke the commit 7b8be49d36fc("NUMA: Enable adding NUMA node implicitly").
>
> The machine_run_board_init() doesn't do NUMA setup if nb_numa_nodes=0,
> but the numa_complete_configuration need add a new node if memory hotplug
> is enabled (slots > 0) even nb_numa_nodes=0.
>
> So, Remove the check for numa_complete_configuration() to fix this.
>
> Fixes 7a3099fc9c5c("numa: postpone options post-processing till
> machine_run_board_init()")
> Signed-off-by: Dou Liyang <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Thanks! Queued on machine-next.
--
Eduardo