Re: [Qemu-devel] [PULL 11/20] docker: filter out linux-user builds for mingw

[Alex Bennée]

Paolo Bonzini <address@hidden> writes:

> On 03/07/2018 12:14, Alex Bennée wrote:
>> The recent change from TARGET_DIRS to TARGET_LIST (208ecb3e1) had the
>> effect of defaulting all docker builds to the current configured set
>> of targets. This is actually reasonable behaviour but does run into
>> problems if you have linux-user builds configured and you want to test
>> the windows cross builds. This commit fixes that by adding a
>> DOCKER_FILTER_TARGETS variable which is special-cased for mingw builds
>> so we don't pass the whole set down.
>
>> +# Special cases
>> +#  mingw/windows builds cannot build linux-user
>> +docker-%-win32-cross: DOCKER_FILTER_TARGETS = %-linux-user
>> +docker-%-win64-cross: DOCKER_FILTER_TARGETS = %-linux-user
>> address@hidden: DOCKER_FILTER_TARGETS = %-linux-user
>
> Some questions:
>
> 1) Any reason to keep all three?

We could prune but it doesn't hurt.

>
> 2) Can we do it in the test script instead?
>
> 3) DEF_TARGET_LIST in the test script becomes meaningless.

Good point.

>
> 4) You now have to override TARGET_LIST with "make
> TARGET_LIST=foo-softmmu address@hidden".  Does this interact
> badly with other uses of TARGET_LIST in the Makefile?

Yeah I originally thought this made sense from the "docker builds the
same as my configured setup" sense but your right that's overkill.

>
> Thanks,
>
> Paolo


--
Alex Bennée