qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 07/32] qmp: Make "id" optional again even in


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 07/32] qmp: Make "id" optional again even in "oob" monitors
Date: Tue, 3 Jul 2018 10:39:46 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 07/03/2018 03:53 AM, Markus Armbruster wrote:
Commit cf869d53172 "qmp: support out-of-band (oob) execution" made
"id" mandatory for all commands when the client accepted capability
"oob".  This is rather onerous when you play with QMP by hand, and
unnecessarily so: only out-of-band commands need an ID for reliable
matching of response to command.

Revert that part of commit cf869d53172 for now, but have documentation
advise on the need to use "id" with out-of-band commands.

Signed-off-by: Markus Armbruster <address@hidden>
---
  docs/interop/qmp-spec.txt | 13 +++++++------
  monitor.c                 |  7 -------
  2 files changed, 7 insertions(+), 13 deletions(-)


@@ -128,6 +125,10 @@ possibly overtaking prior in-band commands.  The client 
may therefore
  receive such a command's response before responses from prior in-band
  commands.
+To be able to match responses back to their commands, the client needs
+to pass "id" with out-of-band commands.  Passing it with all commands
+is recommended for clients that accept capability "oob".

Thanks.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]