qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 15/15] qapi: add conditions to SPICE type/com


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v6 15/15] qapi: add conditions to SPICE type/commands/events on the schema
Date: Tue, 03 Jul 2018 17:05:31 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Marc-André Lureau <address@hidden> writes:

> Add #if defined(CONFIG_SPICE) in generated code, and adjust the
> qmp/hmp code accordingly.
>
> query-qmp-schema no longer reports the command/events etc as
> available when disabled at compile time.
>
> Commands made conditional:
>
> * query-spice
>
>   Before the patch, the command for !CONFIG_SPICE is unregistered. It
>   will fail with the same error.
>
> Events made conditional:
>
> * SPICE_CONNECTED, SPICE_INITIALIZED, SPICE_DISCONNECTED,
>   SPICE_MIGRATE_COMPLETED
>
> Add TODO for conditional SPICE chardevs, delayed until the supports
> for conditional members lands.
>
> No HMP change, the code was already conditional.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Gerd Hoffmann <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]