[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 00/25] OpenRISC updates for 3.0
From: |
Stafford Horne |
Subject: |
Re: [Qemu-devel] [PULL v2 00/25] OpenRISC updates for 3.0 |
Date: |
Tue, 3 Jul 2018 22:53:13 +0900 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Mon, Jul 02, 2018 at 04:36:10PM +0100, Peter Maydell wrote:
> On 2 July 2018 at 16:09, Stafford Horne <address@hidden> wrote:
> > Hi Peter,
> >
> > Changes since v1:
> > - Un"fixed" an incorrect checkpatch warning pointed out by Richard.
> >
> > Please consider for pull.
> >
> > The following changes since commit 646f34fa5482e495483de230b4cf0f2ae4fd2781:
> >
> > tcg: Fix --disable-tcg build breakage (2018-07-02 13:42:05 +0100)
> >
> > are available in the Git repository at:
> >
> > address@hidden:stffrdhrn/qemu.git tags/pull-or-20180702
> >
> > for you to fetch changes up to 33e1acf437ce4f0b67c262fc93b436e2e306f278:
> >
> > target/openrisc: Fix writes to interrupt mask register (2018-07-03
> > 00:05:28 +0900)
> >
> > ----------------------------------------------------------------
> > OpenRISC cleanups and Fixes for QEMU 3.0
> >
> > Mostly patches from Richard Henderson fixing multiple things:
> > * Fix singlestepping in GDB.
> > * Use more TB linking.
> > * Fixes to exit TB after updating SPRs to enable registering of state
> > changes.
> > * Significant optimizations and refactors to the TLB
> > * Split out disassembly from translation.
> > * Add qemu-or1k to qemu-binfmt-conf.sh.
> > * Implement signal handling for linux-user.
> >
> > Then there are a few fixups from me:
> > * Fix delay slot detections to match hardware, this was masking a bug
> > in the linus kernel.
> > * Fix stores to the PIC mask register
> >
> > ----------------------------------------------------------------
>
> Compile failure, for the windows crossbuilds:
>
[...]
> /home/petmay01/qemu-for-merges/target/openrisc/mmu.c:171:23: error:
> 'PROT_READ' undeclared (first use in this function)
> : PROT_READ);
> ^
> /home/petmay01/qemu-for-merges/rules.mak:69: recipe for target
> 'target/openrisc/mmu.o' failed
>
> PROT_READ/WRITE/EXEC are the Posix flags for mmap().
> The flags for the 'prot' argument to tlb_set_page()
> and similar places are PAGE_READ/WRITE/EXEC.
Understood, this should be fixed now, after changing I see no differences.
> PS: for trivial respins of a pullreq you don't need to resend
> the whole thing, you can just resend the cover letter (and
> any individual patches which got major changes).
Thats good to know, I thought it might be annoying to resend the entire series
when all that is needed is the pr cover letter.
I have resent, I hope all is well.
-Stafford
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, (continued)
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Stafford Horne, 2018/07/03
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Richard Henderson, 2018/07/04
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Eric Blake, 2018/07/06
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Stafford Horne, 2018/07/06
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Laurent Vivier, 2018/07/07
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Alex Bennée, 2018/07/07
[Qemu-devel] [PULL v2 25/25] target/openrisc: Fix writes to interrupt mask register, Stafford Horne, 2018/07/02
[Qemu-devel] [PULL v2 24/25] target/openrisc: Fix delay slot exception flag to match spec, Stafford Horne, 2018/07/02
[Qemu-devel] [PULL v2 23/25] linux-user: Fix struct sigaltstack for openrisc, Stafford Horne, 2018/07/02
Re: [Qemu-devel] [PULL v2 00/25] OpenRISC updates for 3.0, Peter Maydell, 2018/07/02
- Re: [Qemu-devel] [PULL v2 00/25] OpenRISC updates for 3.0,
Stafford Horne <=