|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH 20/32] monitor: Peel off @mon_global wrapper |
Date: | Mon, 2 Jul 2018 21:15:10 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/02/2018 11:22 AM, Markus Armbruster wrote:
Wrapping global variables in a struct without a use for the wrapper struct buys us nothing but longer lines. Unwrap them.
Well, it also makes it slightly more obvious where you are using a global variable, and thus need to be careful of reentrancy. But I'm not opposed to this reduction in size.
Signed-off-by: Markus Armbruster <address@hidden> --- monitor.c | 60 +++++++++++++++++++++++++++---------------------------- 1 file changed, 29 insertions(+), 31 deletions(-)
Reviewed-by: Eric Blake <address@hidden> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |