[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 13/13] linux-user/strace: Improve recvfrom()
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v3 13/13] linux-user/strace: Improve recvfrom() output |
Date: |
Mon, 2 Jul 2018 20:44:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
Le 02/07/2018 à 19:50, Philippe Mathieu-Daudé a écrit :
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-By: Guido Günther <address@hidden>
> ---
> linux-user/strace.c | 16 ++++++++++++++++
> linux-user/strace.list | 2 +-
> 2 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index f80d655835..a85b4a10e5 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -2008,6 +2008,22 @@ print_getsockname(const struct syscallname *name,
> }
> #endif
>
> +#if defined(TARGET_NR_recvfrom)
> +static void
> +print_recvfrom(const struct syscallname *name,
> + abi_long arg0, abi_long arg1, abi_long arg2,
> + abi_long arg3, abi_long arg4, abi_long arg5)
> +{
> + print_syscall_prologue(name);
> + print_raw_param("%d", arg0, 0);
> + print_buf(arg1, arg2, 0);
The content of the buffer is not relevant here as it is displayed before
the data are received. I think you should only print the pointer and the
length.
Thanks,
Laurent
- [Qemu-devel] [PATCH v3 06/13] linux-user/strace: Dump AF_NETLINK sockaddr content, (continued)
- [Qemu-devel] [PATCH v3 06/13] linux-user/strace: Dump AF_NETLINK sockaddr content, Philippe Mathieu-Daudé, 2018/07/02
- [Qemu-devel] [PATCH v3 07/13] linux-user/strace: Improve recvmsg() output, Philippe Mathieu-Daudé, 2018/07/02
- [Qemu-devel] [PATCH v3 10/13] linux-user/strace: Let print_sockaddr() have a 'last' argument, Philippe Mathieu-Daudé, 2018/07/02
- [Qemu-devel] [PATCH v3 12/13] linux-user/strace: Improve getsockname() output, Philippe Mathieu-Daudé, 2018/07/02
- [Qemu-devel] [PATCH v3 11/13] linux-user/strace: Add print_sockaddr_ptr() to handle plain/pointer addrlen, Philippe Mathieu-Daudé, 2018/07/02
- [Qemu-devel] [PATCH v3 13/13] linux-user/strace: Improve recvfrom() output, Philippe Mathieu-Daudé, 2018/07/02
- Re: [Qemu-devel] [PATCH v3 13/13] linux-user/strace: Improve recvfrom() output,
Laurent Vivier <=
- Message not available
- Message not available
- Message not available
- Message not available