[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 25/25] target/openrisc: Fix writes to interrupt ma
From: |
Stafford Horne |
Subject: |
[Qemu-devel] [PULL v2 25/25] target/openrisc: Fix writes to interrupt mask register |
Date: |
Tue, 3 Jul 2018 00:10:23 +0900 |
The interrupt controller mask register (PICMR) allows writing any value
to any of the 32 interrupt mask bits. Writing a 0 masks the interrupt
writing a 1 unmasks (enables) the the interrupt.
For some reason the old code was or'ing the write values to the PICMR
meaning it was not possible to ever mask a interrupt once it was
enabled.
I have tested this by running linux 4.18 and my regular checks, I don't
see any issues.
Reported-by: Davidson Francis <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Stafford Horne <address@hidden>
---
target/openrisc/sys_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c
index 541615bfb3..b66a45c1e0 100644
--- a/target/openrisc/sys_helper.c
+++ b/target/openrisc/sys_helper.c
@@ -142,7 +142,7 @@ void HELPER(mtspr)(CPUOpenRISCState *env, target_ulong spr,
target_ulong rb)
}
break;
case TO_SPR(9, 0): /* PICMR */
- env->picmr |= rb;
+ env->picmr = rb;
break;
case TO_SPR(9, 2): /* PICSR */
env->picsr &= ~rb;
--
2.17.0
- [Qemu-devel] [PULL v2 20/25] target/openrisc: Reorg tlb lookup, (continued)
- [Qemu-devel] [PULL v2 20/25] target/openrisc: Reorg tlb lookup, Stafford Horne, 2018/07/02
- [Qemu-devel] [PULL v2 21/25] target/openrisc: Add support in scripts/qemu-binfmt-conf.sh, Stafford Horne, 2018/07/02
- [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Stafford Horne, 2018/07/02
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Philippe Mathieu-Daudé, 2018/07/03
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Stafford Horne, 2018/07/03
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Richard Henderson, 2018/07/04
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Eric Blake, 2018/07/06
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Stafford Horne, 2018/07/06
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Laurent Vivier, 2018/07/07
- Re: [Qemu-devel] [PULL v2 22/25] linux-user: Implement signals for openrisc, Alex Bennée, 2018/07/07
[Qemu-devel] [PULL v2 25/25] target/openrisc: Fix writes to interrupt mask register,
Stafford Horne <=
[Qemu-devel] [PULL v2 24/25] target/openrisc: Fix delay slot exception flag to match spec, Stafford Horne, 2018/07/02
[Qemu-devel] [PULL v2 23/25] linux-user: Fix struct sigaltstack for openrisc, Stafford Horne, 2018/07/02
Re: [Qemu-devel] [PULL v2 00/25] OpenRISC updates for 3.0, Peter Maydell, 2018/07/02