qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] virtio-rng: process pending requests when dr


From: Pankaj Gupta
Subject: Re: [Qemu-devel] [PATCH v2] virtio-rng: process pending requests when driver is ready
Date: Mon, 2 Jul 2018 01:15:21 -0400 (EDT)

> 
> On Wed, Jun 27, 2018 at 04:55:20PM +0530, Pankaj Gupta wrote:
> > +static void virtio_rng_set_status(VirtIODevice *vdev, uint8_t status)
> > +{
> > +    VirtIORNG *vrng = VIRTIO_RNG(vdev);
> > +
> > +    if (!vdev->vm_running) {
> > +        return;
> > +    }
> > +    vdev->status = status;
> 
> Please add a comment to explain this, otherwise someone might think this
> is unnecessary since virtio.c also does it.

Sure. Will add a comment and send v3.

Thanks,
Pankaj



reply via email to

[Prev in Thread] Current Thread [Next in Thread]