|
From: | Stefan Berger |
Subject: | Re: [Qemu-devel] [PATCH v5 4/4] acpi: build TPM Physical Presence interface |
Date: | Thu, 28 Jun 2018 11:53:39 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/28/2018 11:24 AM, Marc-André Lureau wrote:
+ ifctx2 = aml_if(aml_equal(func_idx, aml_int(3))); + { + /* revision to integer */ + aml_append(ifctx2, + aml_store( + aml_to_integer(aml_arg(1)),same do you need cast here, by spec it's 'int' already?Yeah, looks like it's unnecessary. Stefan?
Iirc some things were not working at the beginning when I wrote this ACPI thing and one problem went away by doing this cast, though it may have overlapped with other issues. I cannot say for sure.
[Prev in Thread] | Current Thread | [Next in Thread] |