[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] doc: switch to modern syntx for VNC TLS setup
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] doc: switch to modern syntx for VNC TLS setup |
Date: |
Thu, 28 Jun 2018 09:46:02 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/28/2018 08:28 AM, Paolo Bonzini wrote:
On 28/06/2018 15:22, Eric Blake wrote:
-qemu-system-i386 [...OPTIONS...] -vnc :1,tls,x509=/etc/pki/qemu
-monitor stdio
+qemu-system-i386 [...OPTIONS...] \
+ -object
tls-creds-x509,id=tls0,dir=/etc/pki/qemu,endpoint=server,verify-peer=no
\
I'd use --object here (especially since -object cannot be used on
qemu-nbd, but --object tls-creds-x509 can).
But that would be inconsistent with -vnc.
I honestly don't understand the crusade against single-dashed options.
Rather, it's a crusade FOR the use of --object, for consistency reasons:
These work:
qemu-system-i386 -object foo
qemu-system-i386 --object foo
qemu-nbd --object foo
but this fails:
qemu-nbd -object foo
And since --object blurbs can a) be quite long, and b) be quite useful
for pasting between apps, then it stands to reason that our
documentation should prefer the form that is easiest to reuse everywhere.
Meanwhile, these both work:
qemu-system-i386 -vnc
qemu-system-i386 --vnc
but as no other qemu-* binaries (currently) take a --vnc argument, it's
a moot point as to which form the documentation should prefer for the
purpose of pasting into other binaries. But at the same time,
consistency argues that if we're going to spell --object everywhere,
then we might as well spell --vnc everywhere too.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org