[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 5/7] sm501: Log unimplemented raster operation mo
From: |
BALATON Zoltan |
Subject: |
[Qemu-devel] [PATCH v2 5/7] sm501: Log unimplemented raster operation modes |
Date: |
Tue, 26 Jun 2018 23:18:20 +0200 |
From: Sebastian Bauer <address@hidden>
The sm501 currently implements only a very limited set of raster operation
modes. After this change, unknown raster operation modes are logged so
these can be easily spotted.
Signed-off-by: Sebastian Bauer <address@hidden>
Signed-off-by: BALATON Zoltan <address@hidden>
---
hw/display/sm501.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 08631d5..7404035 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -706,6 +706,8 @@ static void sm501_2d_operation(SM501State *s)
int format_flags = (s->twoD_stretch >> 20) & 0x3;
int addressing = (s->twoD_stretch >> 16) & 0xF;
int rop_mode = (s->twoD_control >> 15) & 0x1; /* 1 for rop2, else rop3 */
+ /* 1 if rop2 source is the pattern, otherwise the source is the bitmap */
+ int rop2_source_is_pattern = (s->twoD_control >> 14) & 0x1;
int rop = s->twoD_control & 0xFF;
/* get frame buffer info */
@@ -719,6 +721,27 @@ static void sm501_2d_operation(SM501State *s)
abort();
}
+ if (rop_mode == 0) {
+ if (rop != 0xcc) {
+ /* Anything other than plain copies are not supported */
+ qemu_log_mask(LOG_UNIMP, "sm501: rop3 mode with rop %x is not "
+ "supported.\n", rop);
+ }
+ } else {
+ if (rop2_source_is_pattern && rop != 0x5) {
+ /* For pattern source, we support only inverse dest */
+ qemu_log_mask(LOG_UNIMP, "sm501: rop2 source being the pattern and
"
+ "rop %x is not supported.\n", rop);
+ } else {
+ if (rop != 0x5 && rop != 0xc) {
+ /* Anything other than plain copies or inverse dest is not
+ * supported */
+ qemu_log_mask(LOG_UNIMP, "sm501: rop mode %x is not "
+ "supported.\n", rop);
+ }
+ }
+ }
+
if ((s->twoD_source_base & 0x08000000) ||
(s->twoD_destination_base & 0x08000000)) {
printf("%s: only local memory is supported.\n", __func__);
--
2.7.6
- [Qemu-devel] [PATCH v2 0/7] Misc sm501 improvements, BALATON Zoltan, 2018/06/26
- [Qemu-devel] [PATCH v2 6/7] sm501: Fix support for non-zero frame buffer start address, BALATON Zoltan, 2018/06/26
- [Qemu-devel] [PATCH v2 7/7] sm501: Set updated region dirty after 2D operation, BALATON Zoltan, 2018/06/26
- [Qemu-devel] [PATCH v2 4/7] sm501: Implement negated destination raster operation mode, BALATON Zoltan, 2018/06/26
- [Qemu-devel] [PATCH v2 5/7] sm501: Log unimplemented raster operation modes,
BALATON Zoltan <=
- [Qemu-devel] [PATCH v2 3/7] sm501: Use values from the pitch register for 2D operations, BALATON Zoltan, 2018/06/26
- [Qemu-devel] [PATCH v2 2/7] sm501: Perform a full update after palette change, BALATON Zoltan, 2018/06/26
- [Qemu-devel] [PATCH v2 1/7] sm501: Implement i2c part for reading monitor EDID, BALATON Zoltan, 2018/06/26
- Re: [Qemu-devel] [PATCH v2 0/7] Misc sm501 improvements, BALATON Zoltan, 2018/06/30