|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH 4/5] pr-manager: add query-pr-managers QMP command |
Date: | Tue, 26 Jun 2018 15:51:31 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/26/2018 10:40 AM, Paolo Bonzini wrote:
This command lets you query the connection status of each pr-manager-helper object. Signed-off-by: Paolo Bonzini <address@hidden> ---
+++ b/qapi/block.json @@ -77,6 +77,33 @@ { 'struct': 'BlockdevSnapshotInternal', 'data': { 'device': 'str', 'name': 'str' } }+##+# @PRManagerInfo: +# +# Information about a persistent reservation manager +# +# @id: the identifier of the persistent reservation manager +# +# @is-connected: whether the persistent reservation manager is connected to +# the underlying storage or helper +# +# Since: 3.0 +## +{ 'struct': 'PRManagerInfo', + 'data': {'id': 'str', 'is-connected': 'bool'} }
Bike-shedding: I think 'connected' is a reasonable (and shorter) name for this member
+ +## +# @query-pr-managers: +# +# Returns a list of information about each persistent reservation manager. +# +# Returns: a list of @PRManagerInfo for each persistent reservation manager +# +# Since: 3.0 +## +{ 'command': 'query-pr-managers', 'returns': ['PRManagerInfo'] } +
As a query command, does it make sense to consider whether this command could be provided during preconfig?
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |