[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] coverity-model: replay data is considered trust
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] coverity-model: replay data is considered trusted |
|
Date: |
Tue, 26 Jun 2018 09:55:39 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 26/06/2018 09:27, Markus Armbruster wrote:
>
> Minimal fix:
>
> diff --git a/scripts/coverity-model.c b/scripts/coverity-model.c
> index 48b112393b..f987ce53b8 100644
> --- a/scripts/coverity-model.c
> +++ b/scripts/coverity-model.c
> @@ -106,6 +106,7 @@ static int get_keysym(const name2keysym_t *table,
> /* Replay data is considered trusted. */
> uint8_t replay_get_byte(void)
> {
> + void *replay_file;
> uint8_t byte = 0;
> if (replay_file) {
> uint8_t c;
>
> Alternatively, dumb down to:
>
> /* Replay data is considered trusted. */
> uint8_t replay_get_byte(void)
> {
> uint8_t byte;
> return byte;
> }
I wonder why the online service didn't complain. I guess the dumber
version is more than enough!
Paolo