Re: [Qemu-devel] [PATCH] osdep: work around Coverity parsing errors

[Peter Maydell]

On 25 June 2018 at 17:06, Paolo Bonzini <address@hidden> wrote:
> Coverity does not like the new _Float* types that are used by
> recent glibc, and croaks on every single file that includes
> stdlib.h.  Add dummy typedefs to please it.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>         I've been using this patch for a couple months, and Peter pointed
>         out that other projects are doing similar hacks.  So it's probably
>         time to send it upstream.
>
>         Note that this is a parse error, so it cannot be fixed in the
>         model file.
>
>  include/qemu/osdep.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index 9ed62423c0..0084f3fa71 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -33,6 +33,14 @@
>  #else
>  #include "exec/poison.h"
>  #endif
> +#ifdef __COVERITY__
> +typedef float _Float32;
> +typedef double _Float32x;
> +typedef double _Float64;
> +typedef __float80 _Float64x;
> +typedef __float128 _Float128;
> +#endif

I think it would help to repeat the rationale in a comment here,
to avoid the necessity to dig it out of the git log.

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM