[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 10/10] linux-user: add gcov support to preexi
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v1 10/10] linux-user: add gcov support to preexit_cleanup |
Date: |
Mon, 25 Jun 2018 13:47:28 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Philippe Mathieu-Daudé <address@hidden> writes:
> Hi Alex,
>
> On 06/25/2018 08:19 AM, Alex Bennée wrote:
>> As we don't always take the normal exit path when running a guest we
>> can skip the normal exit destructors where gcov normally dumps it's
>> info. The GCC manual suggests long running programs use __gcov_dump()
>> to flush out the coverage state periodically so we use that here.
>
> Shouldn't we also check for this symbol in the ./configure script?
Sure - I couldn't find it exported anywhere - just mentioned in the
documentation. I think it has been there a while though.
>
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>
>> ---
>> linux-user/exit.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/linux-user/exit.c b/linux-user/exit.c
>> index aed8713fae..14e94e28fa 100644
>> --- a/linux-user/exit.c
>> +++ b/linux-user/exit.c
>> @@ -19,10 +19,17 @@
>> #include "qemu/osdep.h"
>> #include "qemu.h"
>>
>> +#ifdef CONFIG_GCOV
>> +extern void __gcov_dump(void);
>> +#endif
>> +
>> void preexit_cleanup(CPUArchState *env, int code)
>> {
>> #ifdef TARGET_GPROF
>> _mcleanup();
>> +#endif
>> +#ifdef CONFIG_GCOV
>> + __gcov_dump();
>> #endif
>> gdb_exit(env, code);
>> }
>>
--
Alex Bennée
- Re: [Qemu-devel] [PATCH v1 06/10] travis: add gcovr summary for GCOV build, (continued)
- [Qemu-devel] [PATCH v1 05/10] docker: add gcovr to travis image, Alex Bennée, 2018/06/25
- [Qemu-devel] [PATCH v1 08/10] build-system: add coverage-report target, Alex Bennée, 2018/06/25
- [Qemu-devel] [PATCH v1 07/10] build-system: add clean-coverage target, Alex Bennée, 2018/06/25
- [Qemu-devel] [PATCH v1 10/10] linux-user: add gcov support to preexit_cleanup, Alex Bennée, 2018/06/25
- [Qemu-devel] [PATCH v1 09/10] linux-user: introduce preexit_cleanup, Alex Bennée, 2018/06/25