[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2.5 00/19] tcg queued patches
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PULL v2.5 00/19] tcg queued patches |
Date: |
Fri, 22 Jun 2018 12:23:14 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Jun 22, 2018 at 15:40:33 +0100, Peter Maydell wrote:
(snip)
> /home/petmay01/linaro/qemu-from-laptop/qemu/cpus.c:1637: undefined
> reference to `tcg_register_thread'
> /home/petmay01/linaro/qemu-from-laptop/qemu/cpus.c:1673: undefined
> reference to `cpu_exec_step_atomic'
> cpus.o: In function `qemu_tcg_init_vcpu':
> /home/petmay01/linaro/qemu-from-laptop/qemu/cpus.c:1865: undefined
> reference to `tcg_region_init'
> /home/petmay01/linaro/qemu-from-laptop/qemu/cpus.c:1875: undefined
> reference to `parallel_cpus'
>
> Some of those are probably best handled with stub functions
> (eg tcg_register_thread()), but some of them might be better
> off handled by guarding functions with #ifndef CONFIG_TCG
> or moving them to source files in accel/tcg ?
>
> This is probably best fixed by somebody familiar with the
> commits in question...
Just sent a patch that fixes the --disable-tcg build for me,
tested for x86_64-softmmu and i386-softmmu targets.
However, I'm puzzled by the fact that I cannot replicate all
of the link errors you report above. My build (tried with gcc
5.4.0 and 8.1.0) completes even though I don't see how
some symbols are resolved (I don't see them in the final
binary), e.g. tcg_register_thread().
Is the compiler somehow determining that it doesn't need those?
Thanks,
Emilio
- [Qemu-devel] [PULL v2.5 00/19] tcg queued patches, Richard Henderson, 2018/06/21
- Re: [Qemu-devel] [PULL v2.5 00/19] tcg queued patches, Peter Maydell, 2018/06/22
- Re: [Qemu-devel] [PULL v2.5 00/19] tcg queued patches, Peter Maydell, 2018/06/22
- Re: [Qemu-devel] [PULL v2.5 00/19] tcg queued patches, Peter Maydell, 2018/06/22
- [Qemu-devel] [PATCH] tcg: fix --disable-tcg build breakage introduced by tb_lock removal, Emilio G. Cota, 2018/06/22
- Re: [Qemu-devel] [PATCH] tcg: fix --disable-tcg build breakage introduced by tb_lock removal, Peter Maydell, 2018/06/22
- Re: [Qemu-devel] [PATCH] tcg: fix --disable-tcg build breakage introduced by tb_lock removal, Peter Maydell, 2018/06/22
- Re: [Qemu-devel] [PATCH] tcg: fix --disable-tcg build breakage introduced by tb_lock removal, Emilio G. Cota, 2018/06/22
- Re: [Qemu-devel] [PULL v2.5 00/19] tcg queued patches,
Emilio G. Cota <=