|
From: | Peter Maydell |
Subject: | Re: [Qemu-devel] [PATCH v3 13/19] linux-user: Split out close, open, openat, read, write |
Date: | Fri, 22 Jun 2018 11:38:49 +0100 |
On 12 June 2018 at 01:51, Richard Henderson <address@hidden> wrote: > Signed-off-by: Richard Henderson <address@hidden> > --- > linux-user/syscall.h | 51 ++++ > linux-user/strace.c | 35 --- > linux-user/syscall.c | 402 +------------------------------ > linux-user/syscall_file.c | 423 +++++++++++++++++++++++++++++++++ > linux-user/Makefile.objs | 3 +- > linux-user/gen_syscall_list.py | 5 + > linux-user/strace.list | 15 -- > 7 files changed, 484 insertions(+), 450 deletions(-) > create mode 100644 linux-user/syscall_file.c Reviewed-by: Peter Maydell <address@hidden> > +SYSCALL_IMPL(close) > +{ > + fd_trans_unregister(arg1); > + return get_errno(close(arg1)); > +} > +SYSCALL_DEF(close, ARG_DEC); If in future we wanted to extend the set of information we had for each syscall in the SyscallDef struct, I guess we'd add parameters to the SYSCALL_DEF macro (or have more variant macros)? I can't offhand think of something I'd want to use that for, so it's a bit of an abstract question for the moment. thanks -- PMM
[Prev in Thread] | Current Thread | [Next in Thread] |