[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 12/49] qapi/events: add #if conditions to eve
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 12/49] qapi/events: add #if conditions to events |
Date: |
Fri, 22 Jun 2018 11:02:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Wrap generated code with #if/#endif using an 'ifcontext' on
> QAPIGenCSnippet objects.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> scripts/qapi/events.py | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/qapi/events.py b/scripts/qapi/events.py
> index 26ae00f6f7..dae03e3d88 100644
> --- a/scripts/qapi/events.py
> +++ b/scripts/qapi/events.py
> @@ -185,8 +185,9 @@ class
> QAPISchemaGenEventVisitor(QAPISchemaModularCVisitor):
> genc.add(gen_enum_lookup(self._enum_name, self._event_names))
>
> def visit_event(self, name, info, ifcond, arg_type, boxed):
> - self._genh.add(gen_event_send_decl(name, arg_type, boxed))
> - self._genc.add(gen_event_send(name, arg_type, boxed,
> self._enum_name))
> + with ifcontext(ifcond, self._genh, self._genc):
> + self._genh.add(gen_event_send_decl(name, arg_type, boxed))
> + self._genc.add(gen_event_send(name, arg_type, boxed,
> self._enum_name))
> self._event_names.append(name)
This makes a conditional event's qapi_event_send_FOO() compile-time
conditional, but its enum QAPIEvent member remains unconditional for
now. I figure it'll get its #if in PATCH 29. Please mention this in
your commit message. You do in PATCH 22.