Re: [Qemu-devel] [PATCH v3 24/26] virtio-gpu: split virtio-gpu, introduce virtio-gpu-base

[Gerd Hoffmann]

On Wed, Jun 20, 2018 at 06:04:25PM +0200, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Jun 19, 2018 at 8:43 AM, Gerd Hoffmann <address@hidden> wrote:
> > On Mon, Jun 18, 2018 at 06:17:27PM +0200, Marc-André Lureau wrote:
> >> Add a base class that is common to virtio-gpu and vhost-user-gpu
> >> devices.
> >
> > More verbose commit message please.  What functionality is common and
> > handled by the new (abstract?) base class?  (same for patch #25).
> 
> Would that level of details be enough?

> The VirtIOGPUBase base class provides common functionalities necessary
> for both virtio-gpu and vhost-user-gpu:
> - common configuration (max-outputs, initial resolution, flags)
> - virtio device initialization, including queue setup
> - device pre-conditions checks (iommu)
> - migration blocker
> - virtio device callbacks
> - hooking up to qemu display subsystem
> - a few common helper functions to reset the device, retrieve display
> informations
> - a class callback to unblock the rendering (for GL updates)
> 
> What is left to the virtio-gpu subdevice to take care of, in short,
> are all the virtio queues handling, command processing and migration.

Looks good.

cheers,
  Gerd