[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qapi/introspect: Eliminate pointless variable i
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH] qapi/introspect: Eliminate pointless variable in .visit_end() |
Date: |
Wed, 20 Jun 2018 15:07:59 +0200 |
On Wed, Jun 20, 2018 at 2:47 PM, Markus Armbruster <address@hidden> wrote:
> Commit 1a9a507b2e3 "qapi-introspect: Hide type names" added local
> variable @jsons to improve sorting, but also removed the sorting. It
> was part of a big series that went to v8, and it made sense until v2
> or so...
>
> Commit 7d0f982bfbb replaced @jsons by @qlits, preserving the
> uselessness.
>
> Get rid of it.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> scripts/qapi/introspect.py | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py
> index 5b6c72c7b2..6ad198ae5b 100644
> --- a/scripts/qapi/introspect.py
> +++ b/scripts/qapi/introspect.py
> @@ -75,13 +75,10 @@ class
> QAPISchemaGenIntrospectVisitor(QAPISchemaMonolithicCVisitor):
>
> def visit_end(self):
> # visit the types that are actually used
> - qlits = self._qlits
> - self._qlits = []
> for typ in self._used_types:
> typ.visit(self)
> # generate C
> # TODO can generate awfully long lines
> - qlits.extend(self._qlits)
> name = c_name(self._prefix, protect=False) + 'qmp_schema_qlit'
> self._genh.add(mcgen('''
> #include "qapi/qmp/qlit.h"
> @@ -93,7 +90,7 @@ extern const QLitObject %(c_name)s;
> const QLitObject %(c_name)s = %(c_string)s;
> ''',
> c_name=c_name(name),
> - c_string=to_qlit(qlits)))
> + c_string=to_qlit(self._qlits)))
> self._schema = None
> self._qlits = []
> self._used_types = []
> --
> 2.17.1
>
>
--
Marc-André Lureau