[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/6] tests: iotests: drop some stderr line
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/6] tests: iotests: drop some stderr line |
Date: |
Tue, 19 Jun 2018 12:41:16 +0800 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Fri, Jun 15, 2018 at 10:13:07AM +0200, Markus Armbruster wrote:
> Peter Xu <address@hidden> writes:
>
> > In my Out-Of-Band test, "check -qcow2 060" fail with this:
> >
> > 060 5s ... - output mismatch (see 060.out.bad)
> > --- /home/peterx/git/qemu/tests/qemu-iotests/060.out 2018-06-15
> > 08:31:14.607411950 +0800
> > +++ /home/peterx/git/qemu/bin/tests/qemu-iotests/060.out.bad 2018-06-15
> > 08:33:09.679880113 +0800
> > @@ -427,8 +427,8 @@
> > QMP_VERSION
> > {"return": {}}
> > qcow2: Image is corrupt: L2 table offset 0x2a2a2a00 unaligned (L1 index:
> > 0); further non-fatal corruption events will be suppressed
> > -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> > "event": "BLOCK_IMAGE_CORRUPTED", "data": {"device": "", "msg": "L2 table
> > offset 0x2a2a2a0
> > 0 unaligned (L1 index: 0)", "node-name": "drive", "fatal": false}}
> > read failed: Input/output error
> > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> > "event": "BLOCK_IMAGE_CORRUPTED", "data": {"device": "", "msg": "L2 table
> > offset 0x2a2a2a0
> > 0 unaligned (L1 index: 0)", "node-name": "drive", "fatal": false}}
> > {"return": ""}
> > {"return": {}}
> > {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> > "event": "SHUTDOWN", "data": {"guest": false}}
> > Failures: 060
> > Failed 1 of 1 tests
>
> Please indent this diff; git-am chokes on it for me.
Will do.
>
> > The order of the event and the in/out error line is swapped. I didn't
> > dig up the reason, but AFAIU what we want to verify is the event rather
> > than stderr. Let's drop the stderr line directly for this test.
> >
> > Signed-off-by: Peter Xu <address@hidden>
> >
> > Signed-off-by: Peter Xu <address@hidden>
>
> Lose one S-o-b, please :)
Yeah. :)
--
Peter Xu
- [Qemu-devel] [PATCH v3 0/6] monitor: enable OOB by default, Peter Xu, 2018/06/14
- [Qemu-devel] [PATCH v3 1/6] chardev: comment details for CLOSED event, Peter Xu, 2018/06/14
- [Qemu-devel] [PATCH v3 2/6] monitor: flush qmp responses when CLOSED, Peter Xu, 2018/06/14
- [Qemu-devel] [PATCH v3 3/6] tests: iotests: drop some stderr line, Peter Xu, 2018/06/14
- [Qemu-devel] [PATCH v3 4/6] docs: mention shared state protect for OOB, Peter Xu, 2018/06/14
- [Qemu-devel] [PATCH v3 5/6] monitor: remove "x-oob", turn oob on by default, Peter Xu, 2018/06/14
- [Qemu-devel] [PATCH v3 6/6] Revert "tests: Add parameter to qtest_init_without_qmp_handshake", Peter Xu, 2018/06/14