[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 5/8] docker: docker.py use "ps" to probe usag
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v1 5/8] docker: docker.py use "ps" to probe usage |
Date: |
Mon, 18 Jun 2018 12:00:33 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/18/2018 10:07 AM, Alex Bennée wrote:
> The "images" command is a fairly heavyweight command to run as it
> involves searching the whole docker file-system inventory. On a
> machine with a lot of images this makes start-up fairly expensive.
"version" would be even quicker.
>
> Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/docker/docker.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index c83fd89985..3072bf4a31 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -49,7 +49,7 @@ def _guess_docker_command():
> commands = [["docker"], ["sudo", "-n", "docker"]]
> for cmd in commands:
> try:
> - if subprocess.call(cmd + ["images"],
> + if subprocess.call(cmd + ["ps"],
> stdout=DEVNULL, stderr=DEVNULL) == 0:
> return cmd
> except OSError:
>
- [Qemu-devel] [PATCH v1 0/8] Docker tweaks for TCG testing, Alex Bennée, 2018/06/18
- [Qemu-devel] [PATCH v1 5/8] docker: docker.py use "ps" to probe usage, Alex Bennée, 2018/06/18
- Re: [Qemu-devel] [PATCH v1 5/8] docker: docker.py use "ps" to probe usage,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v1 2/8] docker: extend "cc" command to accept compiler, Alex Bennée, 2018/06/18
- [Qemu-devel] [PATCH v1 8/8] docker: docker.py adding age check command, Alex Bennée, 2018/06/18
- [Qemu-devel] [PATCH v1 1/8] docker: Add "cc" subcommand, Alex Bennée, 2018/06/18
- [Qemu-devel] [PATCH v1 4/8] docker: Makefile.include introduce DOCKER_SCRIPT, Alex Bennée, 2018/06/18
- [Qemu-devel] [PATCH v1 7/8] docker: docker.py add check sub-command, Alex Bennée, 2018/06/18
- [Qemu-devel] [PATCH v1 6/8] docker: docker.py don't conflate checksums for extra_files, Alex Bennée, 2018/06/18
- [Qemu-devel] [PATCH v1 3/8] docker: allow "cc" command to run in user context, Alex Bennée, 2018/06/18