[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions |
|
Date: |
Sat, 16 Jun 2018 19:36:47 -1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/15/2018 12:55 AM, Peter Maydell wrote:
>> + uint32_t armv6m_insn[] = {0xf3808000 /* msr */, 0xf3b08040 /* dsb */,
>> + 0xf3b08050 /* dmb */, 0xf3b08060 /* isb */,
>> + 0xf3e08000 /* mrs */, 0xf000d000 /* bl */};
>> + uint32_t armv6m_mask[] = {0xffe0d000, 0xfff0d0f0, 0xfff0d0f0,
>> + 0xfff0d0f0, 0xffe0d000, 0xf800d000};
> I think these arrays should be 'const'; we can also move them closer
> to their point of use, inside the scope of the if() below.
static as well.
r~
Re: [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions, Peter Maydell, 2018/06/15