[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/18] block: Make remaining uses of qobject
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/18] block: Make remaining uses of qobject input visitor more robust |
Date: |
Fri, 15 Jun 2018 12:36:07 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 14.06.2018 um 21:14 hat Markus Armbruster geschrieben:
> Remaining uses of qobject_input_visitor_new_keyval() in the block
> subsystem:
>
> * block_crypto_create_opts_init()
Still the wrong function name. Will fix this while applying. (Should be
block_crypto_open_opts_init())
> Currently doesn't visit any non-string scalars, thus safe. It's
> called from
> - block_crypto_open_luks()
> Creates the QDict with qemu_opts_to_qdict_filtered(), which
> creates only string scalars, but has a TODO asking for other types.
> - qcow_open()
> - qcow2_open(), qcow2_co_invalidate_cache(), qcow2_reopen_prepare()
>
> * block_crypto_create_opts_init(), called from
> - block_crypto_co_create_opts_luks()
> Also creates the QDict with qemu_opts_to_qdict_filtered().
>
> * vdi_co_create_opts()
> Also creates the QDict with qemu_opts_to_qdict_filtered().
>
> Replace these uses by qobject_input_visitor_new_flat_confused() for
> robustness. This adds crumpling. Right now, that's a no-op, but if
> we ever extend these things in non-flat ways, crumpling will be
> needed.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Kevin
- [Qemu-devel] [PATCH v2 00/18] block: Configuration fixes and rbd authentication, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 01/18] rbd: Drop deprecated -drive parameter "filename", Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 12/18] block-qdict: Clean up qdict_crumple() a bit, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 02/18] iscsi: Drop deprecated -drive parameter "filename", Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 14/18] check-block-qdict: Rename qdict_flatten()'s variables for clarity, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 09/18] block: Make remaining uses of qobject input visitor more robust, Markus Armbruster, 2018/06/14
- Re: [Qemu-devel] [PATCH v2 09/18] block: Make remaining uses of qobject input visitor more robust,
Kevin Wolf <=
- [Qemu-devel] [PATCH v2 11/18] block-qdict: Tweak qdict_flatten_qdict(), qdict_flatten_qlist(), Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 18/18] rbd: New parameter key-secret, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 03/18] block: Add block-specific QDict header, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 13/18] block-qdict: Simplify qdict_is_list() some, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 15/18] check-block-qdict: Cover flattening of empty lists and dictionaries, Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 10/18] block-qdict: Simplify qdict_flatten_qdict(), Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 07/18] block: Clean up a misuse of qobject_to() in .bdrv_co_create_opts(), Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 08/18] block: Factor out qobject_input_visitor_new_flat_confused(), Markus Armbruster, 2018/06/14
- [Qemu-devel] [PATCH v2 16/18] block: Fix -blockdev / blockdev-add for empty objects and arrays, Markus Armbruster, 2018/06/14