Re: [Qemu-devel] [PATCH 1/5] spapr_cpu_core: convert last snprintf() to g_strdup_printf()

[David Gibson]

On Thu, Jun 14, 2018 at 11:50:11PM +0200, Greg Kurz wrote:
> Because this is the preferred practice in QEMU.
> 
> Signed-off-by: Greg Kurz <address@hidden>

Applied to ppc-for-3.0, thanks.

> ---
>  hw/ppc/spapr_cpu_core.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
> index 7e3a9e78d090..27602245fd55 100644
> --- a/hw/ppc/spapr_cpu_core.c
> +++ b/hw/ppc/spapr_cpu_core.c
> @@ -190,7 +190,7 @@ static void spapr_cpu_core_realize(DeviceState *dev, 
> Error **errp)
>  
>      sc->threads = g_new(PowerPCCPU *, cc->nr_threads);
>      for (i = 0; i < cc->nr_threads; i++) {
> -        char id[32];
> +        char *id;
>          CPUState *cs;
>          PowerPCCPU *cpu;
>  
> @@ -208,8 +208,9 @@ static void spapr_cpu_core_realize(DeviceState *dev, 
> Error **errp)
>          /* Set NUMA node for the threads belonged to core  */
>          cpu->node_id = sc->node_id;
>  
> -        snprintf(id, sizeof(id), "thread[%d]", i);
> +        id = g_strdup_printf("thread[%d]", i);
>          object_property_add_child(OBJECT(sc), id, obj, &local_err);
> +        g_free(id);
>          if (local_err) {
>              goto err;
>          }
> 

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature