[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/3] osdep: add wait.h compat macros
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/3] osdep: add wait.h compat macros |
Date: |
Thu, 14 Jun 2018 14:56:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
"Michael S. Tsirkin" <address@hidden> writes:
> Man page for WCOREDUMP says:
>
> WCOREDUMP(wstatus) returns true if the child produced a core dump.
> This macro should be employed only if WIFSIGNALED returned true.
>
> This macro is not specified in POSIX.1-2001 and is not
> available on some UNIX implementations (e.g., AIX, SunOS). Therefore,
> enclose its use inside #ifdef WCOREDUMP ... #endif.
>
> Let's do exactly this.
Sorry to nitpick, but you're not doing "exactly this", you're providing
a stub:
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> include/qemu/osdep.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
> index 4165806..afc28e5 100644
> --- a/include/qemu/osdep.h
> +++ b/include/qemu/osdep.h
> @@ -108,6 +108,16 @@ extern int daemon(int, int);
> #include "qemu/typedefs.h"
>
> /*
> + * According to waitpid man page:
> + * WCOREDUMP
> + * This macro is not specified in POSIX.1-2001 and is not
> + * available on some UNIX implementations (e.g., AIX, SunOS).
> + * Therefore, enclose its use inside #ifdef WCOREDUMP ... #endif.
> + */
> +#ifndef WCOREDUMP
> +#define WCOREDUMP(status) 0
> +#endif
> +/*
> * We have a lot of unaudited code that may fail in strange ways, or
> * even be a security risk during migration, if you disable assertions
> * at compile-time. You may comment out these safety checks if you
Suggest to drop the last sentence from the comment, and have the commit
message state you're providing a stub.
- Re: [Qemu-devel] [PATCH v4 1/3] osdep: add wait.h compat macros,
Markus Armbruster <=