Re: [Qemu-devel] [PATCH] hw/i386: Fix IVHD entry length for AMD IOMMU

[Michael S. Tsirkin]

On Tue, May 22, 2018 at 09:06:56AM +0200, Jan Kiszka wrote:
> On 2018-03-29 14:51, Jan Kiszka wrote:
> > From: Jan Kiszka <address@hidden>
> > 
> > Counting from the IVHD ID field to the all-devices entry, we have 28
> > bytes, not 36.
> > 
> > Signed-off-by: Jan Kiszka <address@hidden>
> > ---
> >  hw/i386/acpi-build.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index deb440f286..a0cda71411 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -2561,7 +2561,7 @@ build_amd_iommu(GArray *table_data, BIOSLinker 
> > *linker)
> >                               (1UL << 7),  /* PPRSup       */
> >                               1);
> >      /* IVHD length */
> > -    build_append_int_noprefix(table_data, 0x24, 2);
> > +    build_append_int_noprefix(table_data, 28, 2);
> >      /* DeviceID */
> >      build_append_int_noprefix(table_data, s->devid, 2);
> >      /* Capability offset */
> > 
> 
> Waiting to be merged.
> 
> Jan

I'll queue this but you really should Cc maintainers :)

-- 
MST