[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments |
Date: |
Wed, 13 Jun 2018 13:30:31 +0100 |
On 12 June 2018 at 18:30, Richard Henderson
<address@hidden> wrote:
> On 06/11/2018 04:17 AM, Peter Maydell wrote:
>> The codebase has a bit of a mix of different multiline
>> comment styles. State a preference for the Linux kernel
>> style:
>> /*
>> * Star on the left for each line.
>> * Leading slash-star and trailing star-slash
>> * each go on a line of their own.
>> */
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> This is not my personal favourite, but seemed to be the
>> closest we had to consensus in the mail thread for v1;
>> I can live with it in order to avoid getting patches which
>> use the styles I like even less :-)
>
> Honestly, I don't like this except for "important" comments.
>
> A "small" comment, e.g. one that doesn't quite fit on a single line, now takes
> 4 lines instead of 2. Which is really annoying and IMO tends to break flow.
That's why I prefer
/* two
* lines
*/
style over kernel-style. But apparently nobody else does...
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments, (continued)
- Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments, Alex Williamson, 2018/06/11
- Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments, Thomas Huth, 2018/06/11
- Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments, John Snow, 2018/06/11
- Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments, Richard Henderson, 2018/06/12
- Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments, John Snow, 2018/06/13
- Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments, Peter Maydell, 2018/06/14
- Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments, John Snow, 2018/06/14
- Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments, Philippe Mathieu-Daudé, 2018/06/14
- Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments, Thomas Huth, 2018/06/15
- Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments, Peter Maydell, 2018/06/15
- Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments, Markus Armbruster, 2018/06/15
Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments, Stefan Hajnoczi, 2018/06/13