[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] util: remove redundant include of glib.h
|
From: |
Peter Xu |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] util: remove redundant include of glib.h and add osdep.h |
|
Date: |
Mon, 11 Jun 2018 10:43:57 +0800 |
|
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Fri, Jun 08, 2018 at 02:16:02PM +0100, Daniel P. Berrangé wrote:
> Code must only ever include glib.h indirectly via the glib-compat.h
> header file, because we will need some macros set before glib.h is
> pulled in. Adding extra includes of glib.h will (soon) cause compile
> failures such as:
>
> In file included from /home/berrange/src/virt/qemu/include/qemu/osdep.h:107,
> from
> /home/berrange/src/virt/qemu/include/qemu/iova-tree.h:26,
> from util/iova-tree.c:13:
> /home/berrange/src/virt/qemu/include/glib-compat.h:22: error:
> "GLIB_VERSION_MIN_REQUIRED" redefined [-Werror]
> #define GLIB_VERSION_MIN_REQUIRED GLIB_VERSION_2_40
>
> In file included from /usr/include/glib-2.0/glib/gtypes.h:34,
> from /usr/include/glib-2.0/glib/galloca.h:32,
> from /usr/include/glib-2.0/glib.h:30,
> from util/iova-tree.c:12:
> /usr/include/glib-2.0/glib/gversionmacros.h:237: note: this is the location
> of the previous definition
> # define GLIB_VERSION_MIN_REQUIRED (GLIB_VERSION_CUR_STABLE)
>
> Furthermore, the osdep.h include should always be done directly from the
> .c file rather than indirectly via any .h file.
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
--
Peter Xu