[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list" |
Date: |
Fri, 8 Jun 2018 18:19:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
Am 08.06.2018 um 11:41 schrieb Dr. David Alan Gilbert:
> * Andreas Färber (address@hidden) wrote:
>> Am 01.06.2018 um 17:39 schrieb Ricardo Perez Blanco:
>>> For debugging purposes it is very useful to:
>>> - See the description of the field. This information is already filled
>>> in but not shown in "qom-list" command.
>>
>> No objection on this part.
>>
>>> - Display value of the field.
>>
>> That is by definition the qom-get operation, not qom-list. Just like the
>> ls command does not show file contents, there's cat etc. for that. For
>> debugging purposes we had a qom-tree (?) command that would combine
>> both.
>
> I'm not too bothered about distinguishing between the two commands;
> but it would be nice - one reason I'm not too bothered is because we've
> failed to get a qom-get in multiple years of trying.
>
>
>> There might be unmerged patches on qemu-devel related to display
>> of certain data types.
>
> Which ones?
My original qom-info series needed StringOutputVisitor changes for enums
(test case: rtc) that did not get accepted immediately and thus some
part of HMP qom-info/qom-get got stuck due to risking assertions for
qom-info / otherwise; QMP was not affected IIRC.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
- [Qemu-devel] [PATCH v2] Show values and description when using "qom-list", Ricardo Perez Blanco, 2018/06/01
- Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list", Eric Blake, 2018/06/01
- Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list", Andreas Färber, 2018/06/02
- Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list", Dr. David Alan Gilbert, 2018/06/08
- Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list",
Andreas Färber <=
- Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list", Perez Blanco, Ricardo (Nokia - BE/Antwerp), 2018/06/11
- Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list", Markus Armbruster, 2018/06/12
- Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list", Markus Armbruster, 2018/06/25
- Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list", Dr. David Alan Gilbert, 2018/06/25
- Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list", Markus Armbruster, 2018/06/25
- Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list", Dr. David Alan Gilbert, 2018/06/29
- Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list", Perez Blanco, Ricardo (Nokia - BE/Antwerp), 2018/06/29