[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/8] parallels: Switch to byte-b
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/8] parallels: Switch to byte-based calls |
Date: |
Thu, 31 May 2018 22:19:49 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, May 31, 2018 at 03:50:39PM -0500, Eric Blake wrote:
> We are gradually moving away from sector-based interfaces, towards
> byte-based. Make the change for the last few sector-based calls
> into the block layer from the parallels driver.
>
> Ideally, the parallels driver should switch to doing everything
> byte-based, but that's a more invasive change that requires a
> bit more auditing.
>
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Reviewed-by: Denis V. Lunev <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
> ---
> block/parallels.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/block/parallels.c b/block/parallels.c
> index 6e9c37f44e1..a761c896d35 100644
> --- a/block/parallels.c
> +++ b/block/parallels.c
> @@ -226,14 +226,15 @@ static int64_t allocate_clusters(BlockDriverState *bs,
> int64_t sector_num,
> };
> qemu_iovec_init_external(&qiov, &iov, 1);
>
> - ret = bdrv_co_readv(bs->backing, idx * s->tracks, nb_cow_sectors,
> - &qiov);
> + ret = bdrv_co_preadv(bs->backing, idx * s->tracks * BDRV_SECTOR_SIZE,
> + nb_cow_bytes, &qiov, 0);
> if (ret < 0) {
> qemu_vfree(iov.iov_base);
> return ret;
> }
>
> - ret = bdrv_co_writev(bs->file, s->data_end, nb_cow_sectors, &qiov);
> + ret = bdrv_co_pwritev(bs->file, s->data_end * BDRV_SECTOR_SIZE,
> + nb_cow_bytes, &qiov, 0);
> qemu_vfree(iov.iov_base);
> if (ret < 0) {
> return ret;
> @@ -339,7 +340,8 @@ static coroutine_fn int
> parallels_co_writev(BlockDriverState *bs,
> qemu_iovec_reset(&hd_qiov);
> qemu_iovec_concat(&hd_qiov, qiov, bytes_done, nbytes);
>
> - ret = bdrv_co_writev(bs->file, position, n, &hd_qiov);
> + ret = bdrv_co_pwritev(bs->file, position * BDRV_SECTOR_SIZE, nbytes,
> + &hd_qiov, 0);
> if (ret < 0) {
> break;
> }
> @@ -378,7 +380,8 @@ static coroutine_fn int
> parallels_co_readv(BlockDriverState *bs,
>
> if (position < 0) {
> if (bs->backing) {
> - ret = bdrv_co_readv(bs->backing, sector_num, n, &hd_qiov);
> + ret = bdrv_co_preadv(bs->backing, sector_num *
> BDRV_SECTOR_SIZE,
> + nbytes, &hd_qiov, 0);
> if (ret < 0) {
> break;
> }
> @@ -386,7 +389,8 @@ static coroutine_fn int
> parallels_co_readv(BlockDriverState *bs,
> qemu_iovec_memset(&hd_qiov, 0, 0, nbytes);
> }
> } else {
> - ret = bdrv_co_readv(bs->file, position, n, &hd_qiov);
> + ret = bdrv_co_preadv(bs->file, position * BDRV_SECTOR_SIZE,
> nbytes,
> + &hd_qiov, 0);
> if (ret < 0) {
> break;
> }
> --
> 2.14.3
>
>
- [Qemu-devel] [PATCH v2 0/8] block: more byte-based cleanups: vectored I/O, Eric Blake, 2018/05/31
- [Qemu-devel] [PATCH v2 2/8] qcow: Switch get_cluster_offset to be byte-based, Eric Blake, 2018/05/31
- [Qemu-devel] [PATCH v2 1/8] parallels: Switch to byte-based calls, Eric Blake, 2018/05/31
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/8] parallels: Switch to byte-based calls,
Jeff Cody <=
- [Qemu-devel] [PATCH v2 3/8] qcow: Switch qcow_co_readv to byte-based calls, Eric Blake, 2018/05/31
- [Qemu-devel] [PATCH v2 4/8] qcow: Switch qcow_co_writev to byte-based calls, Eric Blake, 2018/05/31
- [Qemu-devel] [PATCH v2 5/8] qcow: Switch to a byte-based driver, Eric Blake, 2018/05/31
- [Qemu-devel] [PATCH v2 6/8] replication: Switch to byte-based calls, Eric Blake, 2018/05/31
- [Qemu-devel] [PATCH v2 7/8] vhdx: Switch to byte-based calls, Eric Blake, 2018/05/31
- [Qemu-devel] [PATCH v2 8/8] block: Remove unused sector-based vectored I/O, Eric Blake, 2018/05/31