[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/5] scripts/qemu.py: introduce set_console()
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/5] scripts/qemu.py: introduce set_console() method |
Date: |
Thu, 31 May 2018 11:55:58 +0100 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Wed, May 30, 2018 at 02:41:55PM -0400, Cleber Rosa wrote:
> The set_console() method is intended to ease higher level use cases
> that require a console device.
>
> The amount of intelligence is limited on purpose, requiring either the
> device type explicitly, or the existence of a machine (pattern)
> definition.
>
> Because of the console device type selection criteria (by machine
> type), users should also be able to define that. It'll then be used
> for both '-machine' and for the console device type selection.
>
> Users of the set_console() method will certainly be interested in
> accessing the console device, and for that a console_socket property
> has been added.
>
> Signed-off-by: Cleber Rosa <address@hidden>
> ---
> scripts/qemu.py | 97 ++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 96 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v4 0/5] Acceptance/functional tests, Cleber Rosa, 2018/05/30
- [Qemu-devel] [PATCH v4 2/5] scripts/qemu.py: allow adding to the list of extra arguments, Cleber Rosa, 2018/05/30
- [Qemu-devel] [PATCH v4 3/5] Acceptance tests: add quick VNC tests, Cleber Rosa, 2018/05/30
- [Qemu-devel] [PATCH v4 4/5] scripts/qemu.py: introduce set_console() method, Cleber Rosa, 2018/05/30
- [Qemu-devel] [PATCH v4 5/5] Acceptance tests: add Linux kernel boot and console checking test, Cleber Rosa, 2018/05/30
- [Qemu-devel] [PATCH v4 1/5] Add functional/acceptance tests infrastructure, Cleber Rosa, 2018/05/30