[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC v2 1/4] docs: mention shared state protect for OOB
From: |
Peter Xu |
Subject: |
[Qemu-devel] [RFC v2 1/4] docs: mention shared state protect for OOB |
Date: |
Thu, 31 May 2018 13:16:38 +0800 |
Out-Of-Band handlers need to protect shared state if there is any.
Mention it in the document.
Suggested-by: Markus Armbruster <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
---
docs/devel/qapi-code-gen.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt
index b9b6eabd08..aafc15f100 100644
--- a/docs/devel/qapi-code-gen.txt
+++ b/docs/devel/qapi-code-gen.txt
@@ -680,6 +680,9 @@ OOB command handlers must satisfy the following conditions:
- It does not invoke system calls that may block,
- It does not access guest RAM that may block when userfaultfd is
enabled for postcopy live migration.
+- It needs to protect possilbe shared states, since as long as a
+ command supports Out-Of-Band it means the handler can be run in
+ parallel with the same handler running in the other thread.
If in doubt, do not implement OOB execution support.
--
2.17.0
- [Qemu-devel] [RFC v2 0/4] monitor: enable OOB by default, Peter Xu, 2018/05/31
- [Qemu-devel] [RFC v2 1/4] docs: mention shared state protect for OOB,
Peter Xu <=
- [Qemu-devel] [RFC v2 3/4] monitor: remove "x-oob", turn oob on by default, Peter Xu, 2018/05/31
- [Qemu-devel] [RFC v2 2/4] tests: iotests: don't compare SHUTDOWN event, Peter Xu, 2018/05/31
- [Qemu-devel] [RFC v2 4/4] Revert "tests: Add parameter to qtest_init_without_qmp_handshake", Peter Xu, 2018/05/31
- Re: [Qemu-devel] [RFC v2 0/4] monitor: enable OOB by default, Peter Xu, 2018/05/31