[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] hw/block/fdc: Replace error_setg(&error_abo
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] hw/block/fdc: Replace error_setg(&error_abort) by error_report() + abort() |
Date: |
Wed, 30 May 2018 18:30:58 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 05/30/2018 05:23 PM, John Snow wrote:
> On 05/29/2018 01:48 PM, Philippe Mathieu-Daudé wrote:
>> Use error_report() + abort() instead of error_setg(&error_abort),
>> as suggested by the "qapi/error.h" documentation:
>>
>> Please don't error_setg(&error_fatal, ...), use error_report() and
>> exit(), because that's more obvious.
>> Likewise, don't error_setg(&error_abort, ...), use assert().
>>
>
> Didn't realize this was bad form (Why do we have it?)
>
>> Use abort() instead of the suggested assert() because the error message
>> already got displayed.
>>
>
> Update the suggestion?
Fair enough.
>> Suggested-by: Eric Blake <address@hidden>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>
> Reviewed-by: John Snow <address@hidden>
> Acked-by: John Snow <address@hidden>
Thanks!
- [Qemu-devel] [PATCH 0/4] qapi/error: converts error_setg(&error_fatal) to error_report() + exit(), Philippe Mathieu-Daudé, 2018/05/29
- [Qemu-devel] [PATCH 1/4] hw/block/fdc: Replace error_setg(&error_abort) by error_report() + abort(), Philippe Mathieu-Daudé, 2018/05/29
- [Qemu-devel] [PATCH 2/4] hw/ppc/spapr_drc: Replace error_setg(&error_abort) by error_report() + abort(), Philippe Mathieu-Daudé, 2018/05/29
- [Qemu-devel] [PATCH 3/4] hw/arm/sysbus-fdt: Replace error_setg(&error_fatal) by error_report() + exit(), Philippe Mathieu-Daudé, 2018/05/29
- [Qemu-devel] [PATCH 4/4] device_tree: Replace error_setg(&error_fatal) by error_report() + exit(), Philippe Mathieu-Daudé, 2018/05/29
- Re: [Qemu-devel] [PATCH 0/4] qapi/error: converts error_setg(&error_fatal) to error_report() + exit(), Auger Eric, 2018/05/29