[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 6/7] monitor: move init global earlier
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v9 6/7] monitor: move init global earlier |
Date: |
Wed, 30 May 2018 17:37:34 +0100 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Tue, May 29, 2018 at 01:57:54PM +0800, Peter Xu wrote:
> Before this patch, monitor fd helpers might be called even earlier than
> monitor_init_globals(). This can be problematic.
>
> After previous work, now monitor_init_globals() does not depend on
> accelerator initialization any more. Call it earlier (before CLI
> parsing; that's where the monitor APIs might be called) to make sure it
> is called before any of the monitor APIs.
>
> Suggested-by: Markus Armbruster <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> vl.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v9 0/7] monitor: let Monitor be thread safe, Peter Xu, 2018/05/29
- [Qemu-devel] [PATCH v9 1/7] monitor: rename out_lock to mon_lock, Peter Xu, 2018/05/29
- [Qemu-devel] [PATCH v9 2/7] monitor: protect mon->fds with mon_lock, Peter Xu, 2018/05/29
- [Qemu-devel] [PATCH v9 3/7] monitor: more comments on lock-free elements, Peter Xu, 2018/05/29
- [Qemu-devel] [PATCH v9 4/7] monitor: fix comment for monitor_lock, Peter Xu, 2018/05/29
- [Qemu-devel] [PATCH v9 5/7] monitor: remove event_clock_type, Peter Xu, 2018/05/29
- [Qemu-devel] [PATCH v9 6/7] monitor: move init global earlier, Peter Xu, 2018/05/29
- Re: [Qemu-devel] [PATCH v9 6/7] monitor: move init global earlier,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v9 7/7] monitor: add lock to protect mon_fdsets, Peter Xu, 2018/05/29